Review Request: Fix hang in kcm_useraccount

Rolf Eike Beer kde at opensource.sf-tec.de
Fri Aug 10 16:02:42 BST 2012


Am Samstag 11 August 2012, 00:11:37 schrieb Michael Palimaka:
> On 2012-08-10 02:46, Rolf Eike Beer wrote:
> > Ehm, no. readLine() unconditionally calls readAll(). But that will also
> > clear the input buffer of the process object. So there is nothing left to
> > read on the next readLine() or readAll() call.
> > 
> > Eike
> 
> So you are saying:
> 
> - readAll clears the buffer
> - readLine unconditionally calls readAll
> - readLine may be called multiple times to read multiple lines
> 
> Is that correct?

That's how the code looks to me.

> (Again, I note that in testing, calling readAll then readLine is
> successful.)

I.e. readLine() then returns something? Are you sure this has been written by 
the process before readAll() was called? Strange.

Eike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120810/c56c19e4/attachment.sig>


More information about the kde-core-devel mailing list