Review Request: Fix Calculator keyboard key not working

[Kai Uwe Broulik]

> On Aug. 7, 2012, 6:15 p.m., Lamarque Vieira Souza wrote:
> > kdeui/util/kkeyserver_x11.cpp, line 358
> > <http://git.reviewboard.kde.org/r/105909/diff/1/?file=76478#file76478line358>
> >
> >     I think this will break calculator key for other users. This change also does not make sense, Key_Calculator is a better name for this key than Key_Launch1. My guess is that the keyboard is sending the wrong keysym to Xorg.
> 
> Andreas Pakulat wrote:
>     Calculator key is working just fine on my Microsoft Natural and was working also on a Cherry CyMotion Master Linux I had before. And yes Key_Launch1 is definetly wrong I'd say.

It does not work on my Microsoft Wireless Keyboard 800 or my Wired Keyboard 600. KDE just adds "Start (1)" as key and it does not work. So, Upstream issue?


- Kai Uwe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105909/#review17061
-----------------------------------------------------------


On Aug. 7, 2012, 12:13 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105909/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2012, 12:13 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> This little patch fixes the calculator key not working.
> It is actually the patch created by Leonardo in the bug report.
> 
> 
> This addresses bug 257900.
>     http://bugs.kde.org/show_bug.cgi?id=257900
> 
> 
> Diffs
> -----
> 
>   kdeui/util/kkeyserver_x11.cpp 80a2af4 
> 
> Diff: http://git.reviewboard.kde.org/r/105909/diff/
> 
> 
> Testing
> -------
> 
> Works.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120807/f655d60d/attachment.htm>