Review Request: Fix hang in kcm_useraccount

Michael Palimaka kensington at
Tue Aug 7 19:52:54 BST 2012

This is an automatically generated e-mail. To reply, visit:

(Updated Aug. 7, 2012, 6:52 p.m.)

Review request for KDE Base Apps.


Restore original diff, and add comments explaining it.


When changing the user's full name, chfn may not necessarily produce any output. Since readLine blocks, the kcm may hang.

This change checks if chfn exited without output, and if so, use that exit status.

This addresses bug 156396.

Diffs (updated)

  kdepasswd/kcm/chfnprocess.cpp 9f75d4aa75b41acec84e7798c789d4226ca3fab9 



On a PAM-enabled system:
* Full name changed successfully when permitted by login.defs
* Error presented and no change processed with prohibited by login.defs


Michael Palimaka

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-core-devel mailing list