Review Request: Fix hang in kcm_useraccount

[Oswald Buddenhagen]

> On Aug. 7, 2012, 7:26 a.m., Oswald Buddenhagen wrote:
> > did you look at the changes i did in kdelibs/kdesu a while ago? this should probably go in line with them (i didn't check whether it already does).
> 
> Michael Palimaka wrote:
>     What should I be looking for?

everything. it's not that much. ;)
the "chat" handling should be virtually identical, i think.


- Oswald


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105895/#review17018
-----------------------------------------------------------


On Aug. 7, 2012, 6:52 p.m., Michael Palimaka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105895/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2012, 6:52 p.m.)
> 
> 
> Review request for KDE Base Apps.
> 
> 
> Description
> -------
> 
> When changing the user's full name, chfn may not necessarily produce any output. Since readLine blocks, the kcm may hang.
> 
> This change checks if chfn exited without output, and if so, use that exit status.
> 
> 
> This addresses bug 156396.
>     http://bugs.kde.org/show_bug.cgi?id=156396
> 
> 
> Diffs
> -----
> 
>   kdepasswd/kcm/chfnprocess.cpp 9f75d4aa75b41acec84e7798c789d4226ca3fab9 
> 
> Diff: http://git.reviewboard.kde.org/r/105895/diff/
> 
> 
> Testing
> -------
> 
> On a PAM-enabled system:
> * Full name changed successfully when permitted by login.defs
> * Error presented and no change processed with prohibited by login.defs
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120808/6fee6d49/attachment.htm>