Review Request: Fix Calculator keyboard key not working

Lamarque Vieira Souza lamarque at kde.org
Tue Aug 7 19:15:43 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105909/#review17061
-----------------------------------------------------------



kdeui/util/kkeyserver_x11.cpp
<http://git.reviewboard.kde.org/r/105909/#comment13375>

    I think this will break calculator key for other users. This change also does not make sense, Key_Calculator is a better name for this key than Key_Launch1. My guess is that the keyboard is sending the wrong keysym to Xorg.


- Lamarque Vieira Souza


On Aug. 7, 2012, 12:13 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105909/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2012, 12:13 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> This little patch fixes the calculator key not working.
> It is actually the patch created by Leonardo in the bug report.
> 
> 
> This addresses bug 257900.
>     http://bugs.kde.org/show_bug.cgi?id=257900
> 
> 
> Diffs
> -----
> 
>   kdeui/util/kkeyserver_x11.cpp 80a2af4 
> 
> Diff: http://git.reviewboard.kde.org/r/105909/diff/
> 
> 
> Testing
> -------
> 
> Works.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120807/d062f359/attachment.htm>


More information about the kde-core-devel mailing list