Review Request: Fix Warning messages when closing About popup

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105627/#review16965
-----------------------------------------------------------

Ship it!


Heh, well it's not like KWidgetItemDelegate is maintained, clearly.

No objection to the patch, even though it shows once again that KWidgetItemDelegate is a bit fragile....

This is the warning you get, right?
 kWarning() << "User of KWidgetItemDelegate should not delete widgets created by createItemWidgets!";
Clearly that warning can't differenciate between "developer is deleting my widgets" and "Qt is cleaning up everything". I wonder how similar things are done in Qt itself. I guess there's no warning, but rather proper handling of both cases.

- David Faure


On July 19, 2012, 10:23 p.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105627/
> -----------------------------------------------------------
> 
> (Updated July 19, 2012, 10:23 p.m.)
> 
> 
> Review request for kdelibs, Frederik Gladhorn and David Faure.
> 
> 
> Description
> -------
> 
> There is a too agressive check in KWidgetItemDelegateEventListener that complains about
> "User of KWidgetItemDelegate should not delete widgets created by createItemWidgets!"
> when closing an about dialog.
> 
> I tried making it less agressive but since i could not, i'm just deleting things in a different order in the destruction of KAboutApplicationDialog so that the warning is not triggered and our users get angry
> 
> 
> This addresses bug 301628.
>     http://bugs.kde.org/show_bug.cgi?id=301628
> 
> 
> Diffs
> -----
> 
>   kdeui/dialogs/kaboutapplicationdialog.cpp 2c98f74 
> 
> Diff: http://git.reviewboard.kde.org/r/105627/diff/
> 
> 
> Testing
> -------
> 
> Dialog still works, valgrind doesn't complain, the warning is gone
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120806/9e7b97bc/attachment.htm>