playground/games/picmi moved to KDE Review
jakob.gruber at gmail.com
Sat Aug 4 08:52:34 BST 2012
On 08/04/2012 09:24 AM, Laszlo Papp wrote:
>> Are there any objections or requested changes before Picmi can proceed
>> to kdegames?
> Yes, you have ignored my comments for more than a week with a
> cross-platform issue, and not just on Windows.
Support for the old libkdegames will be removed soon, making both of the
points below nonissues. I already stated as much in both my original
mail and on 07/25.
> Here is what I wrote earlier:
> 1) The current double check is in wrong order unless you have fixed
> this after my mentioning. I think the fallback should be the old, and
> the first citizen should be changed "cmake API".
> 2) I would suggest meaningful warning messages, if the old version is
> found for some reasons. That might be unintentional from the person
> trying to build.
> Best Regards,
> Laszlo Papp
More information about the kde-core-devel