Review Request: Set the parent widget in KIO::SlaveInterface::messageBox

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104351/#review13181
-----------------------------------------------------------

Ship it!


Oh I see, it's a bug in reviewboard.
The method name in the context (above the diff) was wrong.
It said:

[ void ProtoQueue::removeJob(SimpleJob *job) ]
{
    int error;

while in fact the code was from ProtoQueue::createSlave.

Objection withdrawn.

- David Faure


On March 20, 2012, 7:14 p.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104351/
> -----------------------------------------------------------
> 
> (Updated March 20, 2012, 7:14 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> This patch sets the top level window that should be used when displaying message boxes in KIO::SlaveInterface. This is the first step into eliminating those multiple message boxes that are popped up because of the out-process design of KIO. Note that this is not the actual resolution, but the first step.
> 
> 
> Diffs
> -----
> 
>   kio/kio/scheduler.cpp 8d144bb 
>   kio/kio/slaveinterface.h 3cdc2ae 
>   kio/kio/slaveinterface.cpp d2f9f93 
>   kio/kio/slaveinterface_p.h e2ccfe0 
> 
> Diff: http://git.reviewboard.kde.org/r/104351/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120430/93d8e4bf/attachment.htm>