Review Request: Add back and forward key binding in Dolphin

[Mark Gaiser]

> On April 30, 2012, 4:54 p.m., Michael Jansen wrote:
> > As albert said. The default shortcuts for the back acktion are "alt-<left>" and "back key" as can be seen in "kcmshell4 standard_actions".
> > 
> > Dolphin chose to overwrite the back key with backspace. A KAction unfortunately can only have to kshortcuts that trigger it. A design problem. So this bug is unfixable without introducing another bug or some ugly not really working workarounds.
> >
> 
> Mark Gaiser wrote:
>     Ahh cool.. And just removing setShortcuts from the KAction class doesn't seem to be the fix either. Just tried that and it seems to have no effect.
>     What would be the fix for KAction to accept multiple (alternative) shortcuts?

Never mind, i fixed it. However, it requires a change in about everything of KShortcut and some in KAction as well. I don't really know if this can be seen as a "bugfix" or a completely new feature that should end up in KDE Frameworks.. Either way, i will do some cleaning up first and make a patch against the current kdelibs from 4.8 which will show up here on the reviewboard somewhere later today.

As for this fix. Lets leave it like it currently is this till KAction is fixed up.


- Mark


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104796/#review13145
-----------------------------------------------------------


On April 30, 2012, 3:41 p.m., Mark Gaiser wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104796/
> -----------------------------------------------------------
> 
> (Updated April 30, 2012, 3:41 p.m.)
> 
> 
> Review request for KDE Base Apps and Peter Penz.
> 
> 
> Description
> -------
> 
> Bug https://bugs.kde.org/show_bug.cgi?id=181531 requested this. I simply implemented it. This adds support to use the Back and Forward key on your keyboard if you have it.
> 
> 
> This addresses bug 181531.
>     http://bugs.kde.org/show_bug.cgi?id=181531
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphinmainwindow.cpp 699a1a7 
> 
> Diff: http://git.reviewboard.kde.org/r/104796/diff/
> 
> 
> Testing
> -------
> 
> I couldn't test this since i don't have a back/forward key on my keyboard. I did compile it and tested if the current backspace binding is still working and that seems to be working just fine. If someone else could confirm that this patch really works on keyboards that have a back and forward key?
> 
> 
> Thanks,
> 
> Mark Gaiser
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120430/fad6a363/attachment.htm>