Review Request: Minor krazy2 warning fixes

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104785/#review13101
-----------------------------------------------------------



kio/bookmarks/konqbookmarkmenu.cc
<http://git.reviewboard.kde.org/r/104785/#comment10214>

    Please revert such changes.
    
    Widgets have moved to QtWidgets in Qt5, so an explicit QtGui/ is just a way to break compilation later on.
    
    QMenu is QMenu, no need for a module name in front -- especially in a .cc/.cpp file.



kio/kfile/kfilemetadataconfigurationwidget.h
<http://git.reviewboard.kde.org/r/104785/#comment10215>

    Please revert.



kio/kfile/kfilemetadatawidget.h
<http://git.reviewboard.kde.org/r/104785/#comment10216>

    Revert.


- David Faure


On April 29, 2012, 6:48 p.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104785/
> -----------------------------------------------------------
> 
> (Updated April 29, 2012, 6:48 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> The following patch fixes the following krazy2 warnings:
> 
>  - Use const references in Q_FOREACH statements where appropriate.
>  - Normalize yet more signal/slot connections (missing from the first go round).
>  - Use brackets instead of double-quotes for the 'config*' header files.
>  - Fix the #ifdef statements in header files to reflect the header filename.
> 
> I did this a long time ago, but never pushed upstream. As part of my spring clean up I want to push this local changes upstream. Any objections ?
> 
> 
> Diffs
> -----
> 
>   kio/bookmarks/kbookmarkdialog.cc 713ceff 
>   kio/bookmarks/kbookmarkdombuilder.cc 8e0be3c 
>   kio/bookmarks/kbookmarkimporter.cc 08210f7 
>   kio/bookmarks/kbookmarkmanager.cc d8a9cb7 
>   kio/bookmarks/kbookmarkmenu.cc deb973b 
>   kio/bookmarks/konqbookmarkmenu.cc 4fc6be0 
>   kio/kfile/kfilemetadataconfigurationwidget.h 6be2a0d 
>   kio/kfile/kfilemetadataprovider.cpp 8caa0c2 
>   kio/kfile/kfilemetadataprovider_p.h 09d924a 
>   kio/kfile/kfilemetadatareaderprocess.cpp 5103087 
>   kio/kfile/kfilemetadatawidget.h 50ddce9 
>   kio/kfile/kimagefilepreview.cpp 74ef8b7 
>   kio/kio/chmodjob.cpp 85e0c2c 
>   kio/kio/jobuidelegate.cpp 85679c2 
>   kio/kio/kautomount.h 9ca5388 
>   kio/kio/kdesktopfileactions.cpp edf2e9c 
>   kio/kio/kfilemetainfoitem.cpp 1cab458 
>   kio/kio/ksambasharedata.cpp aebcb04 
>   kio/misc/kpac/proxyscout.cpp 0068ce7 
>   kio/misc/kpac/script.cpp a595301 
>   nepomuk/core/resourcedata.cpp d6b0121 
> 
> Diff: http://git.reviewboard.kde.org/r/104785/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120429/65f93b2b/attachment.htm>