Review Request: kjs: Implement Object.freeze & Object.isFrozen

Maks Orlovich maksim at kde.org
Sun Apr 29 19:33:43 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104748/#review13094
-----------------------------------------------------------

Ship it!


Again, looks find except for ->toString in exception messages being risky.


- Maks Orlovich


On April 26, 2012, 8:53 p.m., Bernd Buschinski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104748/
> -----------------------------------------------------------
> 
> (Updated April 26, 2012, 8:53 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> kjs: Implement Object.freeze & Object.isFrozen
> 
> depends on https://git.reviewboard.kde.org/r/104746/
> 
> 
> Diffs
> -----
> 
>   kjs/object_object.cpp 986f03f 
> 
> Diff: http://git.reviewboard.kde.org/r/104748/diff/
> 
> 
> Testing
> -------
> 
> ecmascript 15.2.3.9 tests
>  
> 
> 
> Thanks,
> 
> Bernd Buschinski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120429/926dd30f/attachment.htm>


More information about the kde-core-devel mailing list