Review Request: kjs: Implement Object.defineProperties

[Maks Orlovich]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104629/#review13090
-----------------------------------------------------------

Ship it!


Looks OK modulo generic remarks on use of ->toString which will be coming with the big important review. And, of course, the prereqs.


- Maks Orlovich


On April 16, 2012, 11:02 p.m., Bernd Buschinski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104629/
> -----------------------------------------------------------
> 
> (Updated April 16, 2012, 11:02 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> This requieres https://git.reviewboard.kde.org/r/104515/ and https://git.reviewboard.kde.org/r/104511/
> 
> Its pretty much straight forward, but needs Object.defineProperty
> 
> 
> Diffs
> -----
> 
>   kjs/object_object.cpp 986f03f 
>   kjs/propertydescriptor.h PRE-CREATION 
>   kjs/propertydescriptor.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/104629/diff/
> 
> 
> Testing
> -------
> 
> ecmascript & daily browsing
> 
> 
> Thanks,
> 
> Bernd Buschinski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120429/9100e857/attachment.htm>