Review Request: bilinear scaling for khtml/imload
Allan Sandfeld Jensen
kde at carewolf.com
Thu Apr 26 22:23:23 BST 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104743/#review12945
-----------------------------------------------------------
Looks good, but I think you need to disable it or do something very different for 8bit color images.
- Allan Sandfeld Jensen
On April 26, 2012, 6:54 p.m., Martin Tobias Holmedahl Sandsmark wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104743/
> -----------------------------------------------------------
>
> (Updated April 26, 2012, 6:54 p.m.)
>
>
> Review request for kdelibs.
>
>
> Description
> -------
>
> Uses bilinear scaling for images. It's a bit prettier, but not much, but should be a reasonable tradeoff for speed.
>
>
> Diffs
> -----
>
> khtml/imload/scaledimageplane.h 35fec21
> khtml/imload/scaledimageplane.cpp 4977201
>
> Diff: http://git.reviewboard.kde.org/r/104743/diff/
>
>
> Testing
> -------
>
> ran it against a couple of different images of various sizes.
>
>
> Screenshots
> -----------
>
> Before
> http://git.reviewboard.kde.org/r/104743/s/547/
> After
> http://git.reviewboard.kde.org/r/104743/s/548/
>
>
> Thanks,
>
> Martin Tobias Holmedahl Sandsmark
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120426/64f698b1/attachment.htm>
More information about the kde-core-devel
mailing list