Review Request: "data:" protocol: don't treat fragments as part of the data

Rolf Eike Beer kde at opensource.sf-tec.de
Thu Apr 26 17:31:08 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104624/
-----------------------------------------------------------

(Updated April 26, 2012, 4:31 p.m.)


Review request for kdelibs.


Changes
-------

Incorporated the comments from David Faure.


Description
-------

The testcases at http://greenbytes.de/tech/tc/datauri/ show that we incorrectly take the fragment (that's everything starting with the #) in a link containing a data URL as part of the URL. Fix it ;)


Diffs (updated)
-----

  kio/kio/dataprotocol.cpp ea95de4 
  kio/tests/dataprotocoltest.cpp 44410de 

Diff: http://git.reviewboard.kde.org/r/104624/diff/


Testing
-------

Old unittests still pass, new ones now also.


Thanks,

Rolf Eike Beer

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120426/c07e351e/attachment.htm>


More information about the kde-core-devel mailing list