kde-thumbnail-po in kdereview WAS Re: import kde-thumbnail-po into kdesdk

[Albert Astals Cid]

El Dilluns, 23 d'abril de 2012, a les 14:41:40, nihui水竹院落 va escriure:
> hi
> 
> the code has already been in kdereview now.[1]

I'd like that you changed the
find_library(GETTEXTPO_LIBRARY NAMES gettextpo REQUIRED)
to

macro_optional_find_package
macro_log_feature
macro_display_feature_log

so once it's in kdesdk it behaves like a good citizen disabling itself from 
build instead of breaking the build for people not having that library.

The rest looks good :-)

Cheers,
  Albert

> 
> regards,
> nihui
> 
> [1] http://websvn.kde.org/?view=revision&revision=1291261