Review Request: kjs: Implement Array.isArray

Maks Orlovich maksim at kde.org
Sat Apr 21 16:50:58 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104676/#review12766
-----------------------------------------------------------

Ship it!



kjs/array_object.cpp
<http://git.reviewboard.kde.org/r/104676/#comment9978>

    Again, can just call getObject and check is vs. NULL to make this marginally faster.


- Maks Orlovich


On April 19, 2012, 7:41 p.m., Bernd Buschinski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104676/
> -----------------------------------------------------------
> 
> (Updated April 19, 2012, 7:41 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> kjs: Implement Array.isArray
> 
> strictly to ECMA Edition 5.1 r6 - 15.4.3.2
> 
> 
> Diffs
> -----
> 
>   kjs/array_object.cpp 7538ba1 
> 
> Diff: http://git.reviewboard.kde.org/r/104676/diff/
> 
> 
> Testing
> -------
> 
> ecmascript 15.4.3.2 tests
> 
> 
> Thanks,
> 
> Bernd Buschinski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120421/02f65ed8/attachment.htm>


More information about the kde-core-devel mailing list