Review Request: KJS: Implement Object.prototypeOf, Object.keys, Object.getOwnPropertyNames

Bernd Buschinski b.buschinski at
Thu Apr 19 21:35:33 BST 2012

This is an automatically generated e-mail. To reply, visit:

(Updated April 19, 2012, 8:35 p.m.)

Review request for kdelibs.


Updated Array getOwnPropertyNames to 3 parameter version, so it will work again alone after this patch
(the following patch will change it again anyway, but its good to keep it working after every commit)


KJS: Implement Object.prototypeOf, Object.keys, Object.getOwnPropertyNames

NOTE: Array was left out on purpose, as currentl imeplementation does not save attributes (next patch will fix this)

keys&GetOwnPropertyNames requieres to change the JSObject::getOwnPropertyNames implementation,
for future use a enum is better than than a bool, maybe there will be more ways to include/exclude properties.

All changes for khtml/ecma/ are to silense the -Woverloaded-virtual warnings

Diffs (updated)

  khtml/ecma/kjs_css.h aba44b8 
  khtml/ecma/kjs_css.cpp e3e7417 
  khtml/ecma/kjs_dom.h d0433c3 
  khtml/ecma/kjs_dom.cpp 5fff7e3 
  khtml/ecma/kjs_html.h 0f3f544c 
  khtml/ecma/kjs_html.cpp e3da95c 
  khtml/ecma/kjs_scriptable.h af5343c 
  khtml/ecma/kjs_scriptable.cpp 5d4ea68 
  kjs/JSVariableObject.h a8f01eb 
  kjs/JSVariableObject.cpp b00ef76 
  kjs/array_instance.h 3f2b630 
  kjs/array_instance.cpp fe9b8b4 
  kjs/function.h 3757fe8 
  kjs/function.cpp 5f39ae6 
  kjs/object.h 047c242 
  kjs/object.cpp c19122f 
  kjs/object_object.cpp 986f03f 
  kjs/property_map.h 6b127ff 
  kjs/property_map.cpp b2ff08e 
  kjs/string_object.h e890d52 
  kjs/string_object.cpp 170e2f7 



ecma script & daily surfing


Bernd Buschinski

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-core-devel mailing list