Review Request: kjs: All prototype constructor should be [[Writable]]: true, [[Enumerable]]: false, [[Configurable]]: true

Bernd Buschinski b.buschinski at googlemail.com
Thu Apr 19 20:41:33 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104680/
-----------------------------------------------------------

Review request for kdelibs.


Description
-------

kjs: All prototype constructor should be [[Writable]]: true, [[Enumerable]]: false, [[Configurable]]: true


As said in ECMA Edition 5.1r6 - 15.1:

"Unless otherwise specified, the standard built-in properties of the global object have attributes {[[Writable]]: true, [[Enumerable]]: false, [[Configurable]]: true}."

And it is not otherwise specified.


Diffs
-----

  kjs/interpreter.cpp cf1acf1 

Diff: http://git.reviewboard.kde.org/r/104680/diff/


Testing
-------

Confirmed by ecmascript tests checking the attributes of *.prototype.constrictor with Object.getOwnPropertyDescriptor
like
Object.getOwnPropertyDescriptor(Date.prototype, "constructor");


Thanks,

Bernd Buschinski

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120419/604c8979/attachment.htm>


More information about the kde-core-devel mailing list