Review Request: Ensure authentication data is cached properly in Dolphin

[Dawit Alemayehu]

> On April 16, 2012, 2:03 p.m., Peter Penz wrote:
> > Thanks for the patch, I've not been aware that this caching-issue can be solved like this :-) I guess this patch has not been applied to the latest master: DolphinView does not have a dir-lister anymore (it has been moved to KFileItemModel). Anyhow: Please just let me rebase the patch myself so that I can catch all cases - I'll push the patch to master during the next days.

Ahh indeed. I forgot to update kde-baseapps before creating the patch. :(  As far as not being aware of resolving password caching issues this was, I guess that is my failure for not informing people about such things. I will have to start blogging about such issues in the future. Anyhow, I will let you deal with it.

BTW, on a related not, is it a good idea to call KDirLister from a KIO slave as it is currently being done in src/search/filenamesearchprotocol.cpp ? After all KDirLister itself relies on KIO itself. Why not simply use QDir::entryList or QDir::entryInfoList ? Since ioslaves are run in a different process, the fact that those two functions are blocking functions won't much matter.


- Dawit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104614/#review12509
-----------------------------------------------------------


On April 16, 2012, 1:26 p.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104614/
> -----------------------------------------------------------
> 
> (Updated April 16, 2012, 1:26 p.m.)
> 
> 
> Review request for KDE Base Apps and Peter Penz.
> 
> 
> Description
> -------
> 
> The attached patch sets the main window on the main directory lister in DolphinView and KIO jobs in DolphinMainWindow to ensure that login data for remote protocols such as sftp, ftp are cached properly for the duration of the application. Otherwise, the end user is going to end up being unnecessarily re-prompted to enter password login information.
> 
> Please note that this patch does not address every use of KIO or KDirLister in Dolphin. There are other places in Dolphin's code where directory listers and/or jobs are used without setting the main window.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphinmainwindow.cpp 947db77 
>   dolphin/src/views/dolphinview.cpp 78fd56d 
> 
> Diff: http://git.reviewboard.kde.org/r/104614/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120416/a91cd349/attachment.htm>