Review Request: Make nepomuk runner remove undesired matches

[Sebastian Trueg]

> On April 15, 2012, 5:21 p.m., Sebastian Trueg wrote:
> > This is actually a bug that needs to be addressed differently. Your solution is simply a hack. Normally Nepomuk should not return those results at all. The question is though: why does it? Only if we figure that out we can fix it properly.
> 
> Lamarque Vieira Souza wrote:
>     I have no idea why nepomuk returns those items, it also does it in Plasma Desktop 4.8.2 (search for the word 'document'). I am not an expert in nepomuk and it is very complicated to debug nepomuk's internals. If you have a better idea on how to prevent those items from showing up in query results I am all ears.

I know where the problem would be located. However, I cannot reproduce it with 4.8.x.


- Sebastian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104526/#review12482
-----------------------------------------------------------


On April 9, 2012, 10:29 p.m., Lamarque Vieira Souza wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104526/
> -----------------------------------------------------------
> 
> (Updated April 9, 2012, 10:29 p.m.)
> 
> 
> Review request for KDE Runtime.
> 
> 
> Description
> -------
> 
> Nepomuk runner returns matches like "global namespace", "local namespace" and "PaginatedTextDocument" which pollutes the query's returned matches. This patch adds a NegationTerm to the nepomuk query to filter them. If somebody has a better way to prevent those matches from appearing please let me know.
> 
> 
> This addresses bug 284553.
>     http://bugs.kde.org/show_bug.cgi?id=284553
> 
> 
> Diffs
> -----
> 
>   plasma/generic/runners/nepomuksearch/queryclientwrapper.h 48c1eaa 
>   plasma/generic/runners/nepomuksearch/queryclientwrapper.cpp 0b828b0 
> 
> Diff: http://git.reviewboard.kde.org/r/104526/diff/
> 
> 
> Testing
> -------
> 
> Works in my Plasma Active installation.
> 
> 
> Thanks,
> 
> Lamarque Vieira Souza
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120416/82ed629f/attachment.htm>