Review Request: Fix wrong time zone abbreviation being returned for early dates

[David Jarvie]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104599/
-----------------------------------------------------------

Review request for kdelibs.


Description
-------

KTzfileTimeZone, and therefore time zones provided by KSystemTimeZones, returns the wrong time zone abbreviation for dates earlier than the start of time zone data in the time zone configuration file. This patch fixes that, but requires a new variant of the setPhases() method to be added to KTimeZone. The existing variant of setPhases() will be marked as deprecated. Note that this method is only for use by classes derived from KTimeZone, so the number of users of these methods will be very limited (as far as I know, only ICalTimeZone in kdepimlibs).


Diffs
-----

  kdecore/date/ktimezone.h f591747 
  kdecore/date/ktimezone.cpp 076d459 
  kdecore/date/ktzfiletimezone.cpp 1ebca9d 
  kdecore/tests/ktimezonestest.cpp 3a2402e 

Diff: http://git.reviewboard.kde.org/r/104599/diff/


Testing
-------

KTimeZone unit test now works after removing the temporary bodge put in because of this bug.


Thanks,

David Jarvie

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120414/48ff7ceb/attachment.htm>