Review Request: fix kio_sftp login after pressing cancel in the retry dialog

Dawit Alemayehu adawit at
Tue Apr 10 05:52:20 BST 2012

This is an automatically generated e-mail. To reply, visit:

Review request for KDE Runtime and Andreas Schneider.


The following patch address a scenario the following sftp login related patches:

missed. Namely, what happens if the user presses cancel not in the original password dialog, but rather in the subsequent retry dialog. This could happen if the user made a typo when entering login and password originally. With this patch all the scenarios work as advertised and kio_sftp behaves almost exactly the same as kio_ftp.


  kioslave/sftp/kio_sftp.cpp cfd9bcf 



Repeat the testing outlined in, but with the following change:

In step #1, instead of pressing cancel in the password dialog, enter incorrect login/password. Wait for the the retry dialog to pop up, and then press cancel.


Dawit Alemayehu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-core-devel mailing list