Review Request: GlobalShortcuts Plugin for ActivityManager (kamd)

makis marimpis makhsm at
Wed Apr 4 07:56:07 BST 2012

This is an automatically generated e-mail. To reply, visit:

(Updated April 4, 2012, 6:56 a.m.)

Review request for KDE Base Apps, KDE Runtime, Plasma, and Ivan Čukić.


Converted the rest of the dbus calls to async using the code provided by Lamarque Vieira Souza.
Still logging in to KDE is slow.

In the weekend, i tried some threading code (by moving most of the dbus calls to a qthread object) but still no progress.

Maybe modifying SharedInfo class would be the best option.


(follows discarded review: 104391)

The plugin adds global keyboard shortcuts for changing the activity.
Defaults start from Qt::MetaModifier + Qt::Key_F1.

Initially, this functionality was implemented (without correct results) using KActitivities::Controller.
Using DBus seems fine, just that... it forces kamd to start with 3-4 seconds delay - so it really needs modification/and i would like more guidance related to dbus :D.
Other than that, feedback is needed. 

This addresses bugs 265069 and 273467.

Diffs (updated)

  service/plugins/CMakeLists.txt 3e965c0a201a7eee2c9868fcf163cf55af636858 
  service/plugins/globalshortcuts/CMakeLists.txt PRE-CREATION 
  service/plugins/globalshortcuts/activitymanager-plugin-globalshortcuts.desktop PRE-CREATION 
  service/plugins/globalshortcuts/globalshortcuts.h PRE-CREATION 
  service/plugins/globalshortcuts/globalshortcuts.cpp PRE-CREATION 



Logged in.
Used the default shortcuts to switch activities.
It works!


makis marimpis

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-core-devel mailing list