Review Request: Fix HTTPProtocol::put

Dawit Alemayehu adawit at kde.org
Fri Sep 30 13:30:06 BST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102743/
-----------------------------------------------------------

Review request for kdelibs and Andreas Hartmetz.


Description
-------

Fix the regression caused by a patch that addressed bug# 60898 some 8 years ago.
    
The client should handle the message body returned by the server as a result of a PUT request since the only difference between a PUT and POST action is how the Request-URI is supposed to be handled by the server. See RFC 2616 section 9.6.
    
More importantly this patch should fix the annoying and intermittent "server error" message that pops up when using git.reviewboard.kde.org.


Diffs
-----

  kioslave/http/http.h b337e96 
  kioslave/http/http.cpp ca84f86 

Diff: http://git.reviewboard.kde.org/r/102743/diff/diff


Testing
-------

- Log into git.reviewboard.kde.org
- Create a sample review request.
- Attempt to change the "People:" assigned to it.
- If you do not get a server error message, then try to "Discard" your changes.


Thanks,

Dawit Alemayehu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110930/72c4b370/attachment.htm>


More information about the kde-core-devel mailing list