Review Request: Fix Object::connect: No such slot AbstractItemView::iconSettingsChanged(int)

Aaron J. Seigo aseigo at kde.org
Fri Sep 30 08:06:54 BST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102719/#review6941
-----------------------------------------------------------

Ship it!


yes, the slot moved to the FolderView class itself, so this is no longer needed here.

- Aaron J. Seigo


On Sept. 27, 2011, 4:31 p.m., Romain Perier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102719/
> -----------------------------------------------------------
> 
> (Updated Sept. 27, 2011, 4:31 p.m.)
> 
> 
> Review request for KDE Base Apps.
> 
> 
> Description
> -------
> 
> Hi, there are a lot of "Object::connect: No such slot AbstractItemView::iconSettingsChanged(int)" in my ~/.xsession-errors -> in folderview there is no AbstractItemView::iconSettingsChanged(int). Also, no such slot can be connected to KGlobalSettings::iconChanged(int) in this class.
> 
> My proposal: remove the line connecting the signal to the unexisting slot :)
> 
> 
> Diffs
> -----
> 
>   plasma/applets/folderview/abstractitemview.cpp 2634650 
> 
> Diff: http://git.reviewboard.kde.org/r/102719/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Romain Perier
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110930/73b77409/attachment.htm>


More information about the kde-core-devel mailing list