Review Request: Fix KPasswdServer usage of KWallet

Ben Cooksley bcooksley at kde.org
Thu Sep 29 06:37:44 BST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102729/
-----------------------------------------------------------

Review request for KDE Runtime, Dawit Alemayehu and David Faure.


Description
-------

As of commit 2317acb1da0eefef322d9bac046187fc067cc27b (by adawit) KWallet is never used for password storage by KPasswdServer. It still reads, but never writes. This patch very roughly fixes it to get password saving in KWallet functional again.

There is probably a much nicer way to fix it, but I just wanted it to work again.


Diffs
-----

  kpasswdserver/kpasswdserver.cpp cc8ded2 

Diff: http://git.reviewboard.kde.org/r/102729/diff/diff


Testing
-------

Checking the "Save Password" box when KWallet is enabled leads to the password being saved.


Thanks,

Ben Cooksley

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110929/79dc5449/attachment.htm>


More information about the kde-core-devel mailing list