Review Request: Reset password field to be empty for subsequent attempts to open the wallet

[Valentin Rusu]

On 09/27/2011 01:38 PM, Ralf Jung wrote:
> Hi,
>
> On Tuesday 27 September 2011 12:15:47 Sebastian Kügler wrote:
>> On Monday, September 26, 2011 21:59:04 Ralf Jung wrote:
>>> http://git.reviewboard.kde.org/r/102714/
>>>
>>> When the first attempt to open a wallet fails, clear the password field
>>> for the second one
>> What is the advantage of this over selecting the password? Typing a new one
>> is exactly the same amount of keystrokes, and having the "wrong" password
>> filled in gives a hint at what went wrong. I often see "ow, that many
>> letters, then I mistyped this and that. It also makes it harder to correct
>> mistakes by just editing a part.
>>
>> I might be missing something here, but not clearing (but selecting) seems
>> like a better compromise. No?
> Indeed, that would have the same result. And if I just tested correctly that 
> is already the default behaviour with KDE 4.7? I am still at 4.6 for my main 
> system, so I did not notice that this was changed... sorry.
Now, that I committed Ralf's proposed solution, I'd like to know what
would be your proposal: let it as is, or revert that commit?

-- 
Valentin Rusu (IRC valir, KDE vrusu)
KSecretsService (former KSecretService, KWallet replacement)