Review Request: Show removable media in Dolphin's "Copy To" and "Move To" context menus

[Rajeesh K Nambiar]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102657/
-----------------------------------------------------------

(Updated Sept. 22, 2011, 7:30 p.m.)


Review request for Dolphin and KDE Base Apps.


Changes
-------

Thanks for the review, Christoph!

I've tried to use Places which seems to work nicely, but no devices (Fixed/Removable media) are displayed. See the attached screenshot, where on the Dolphin Places panel all the devices are listed, but not on the "Copy To" menu. Am I missing something?


Summary
-------

The most common usage for "{Copy,Move} To" dolphin context menus is that a user wants to copy/move a selected file to plugged in USB drive. Show the mounted removable media also along with "Root Folder" and recently used entries.

It would be nice to have "Places" sidebar instead of the current implementation, which includes Root Folder, Home Folder, Desktop Folder, other drives including removable media like USB drives etc. See bugs 140475, 251151 et al. This should also help in scenario where plugged in removable media is not automatically mounted (which is the default setup at least in Fedora). I couldn't find a way to easily extend that functionality, though.


This addresses bug 251151.
    http://bugs.kde.org/show_bug.cgi?id=251151


Diffs (updated)
-----

  lib/konq/konq_copytomenu.cpp ca1d963 

Diff: http://git.reviewboard.kde.org/r/102657/diff


Testing
-------

Tested in KDE SC 4.7.0 in Fedora and also by another ArchLinux user.


Screenshots
-----------

Places without Devices
  http://git.reviewboard.kde.org/r/102657/s/268/


Thanks,

Rajeesh

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110922/3c51d379/attachment.htm>