Review Request: Update tab labels list after moving when using QTabWidget::setMovable()

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102628/#review6732
-----------------------------------------------------------


Looks good to me. I've attached a unit test to the bug report - would be nice if you could include it in your commit :-)

- Frank


On Sept. 16, 2011, 1:14 a.m., Christoph Feck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102628/
> -----------------------------------------------------------
> 
> (Updated Sept. 16, 2011, 1:14 a.m.)
> 
> 
> Review request for kdelibs and Eike Hein.
> 
> 
> Summary
> -------
> 
> Not sure if (and how) we must handle indexes outside range.
> 
> 
> This addresses bug 282017.
>     http://bugs.kde.org/show_bug.cgi?id=282017
> 
> 
> Diffs
> -----
> 
>   kdeui/widgets/ktabwidget.h c9964a6 
>   kdeui/widgets/ktabwidget.cpp f8185e2 
> 
> Diff: http://git.reviewboard.kde.org/r/102628/diff
> 
> 
> Testing
> -------
> 
> Tested okey with Konversation.
> 
> 
> Thanks,
> 
> Christoph
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110922/64e90583/attachment.htm>