Review Request: show a warning message when there are more sessions to close

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102588/#review6476
-----------------------------------------------------------


"Probably, it will be better if the new label be in red color"

never use hardcoded colours, as that causes problems for accessibility and themability.

in any case, i'd rather see a real fix for this than making the existing dialog more cluttered and filled with technical information. there are a number of ways of addressing this, but the most natural feeling might be to show the user what the active sessions are as soon as they press "reboot" or "shutdown". this should probably be done in the same dialog (to avoid dialogs going away and coming back, which always looks ugly), replacing the UI that was previously there. something, perhaps, like:

"The following sessions are currently active on this computers, preventing an immediate [reboot|shutdown]:

 * List
 * Of
 * Sessions

Would you like to terminate these other sessions and [reboot|shutdown] or only log out of this current session?

                        ( Log out only )   ( [ Reboot | Shutdown ] )"

if we can't make KDM terminate the other sessions until the current session is done, but perhaps also let them know at this point that they will be prompted to terminate these other sessions after logout.

- Aaron J.


On Sept. 12, 2011, 4:32 p.m., Jaime Torres Amate wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102588/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2011, 4:32 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> This is not a proper fix for the bug, but helps to know that when you press the shutdown or reboot button it will not be shutting down nor rebooting until you press another button or manually close the other sessions.
> 
> Is it possible to add a Warning icon in the button (instead of (*))?
> Probably, it will be better if the new label be in red color? Am I right?
> 
> 
> This addresses bug 183274.
>     http://bugs.kde.org/show_bug.cgi?id=183274
> 
> 
> Diffs
> -----
> 
>   ksmserver/shutdowndlg.h e5f0942 
>   ksmserver/shutdowndlg.cpp 57d9652 
> 
> Diff: http://git.reviewboard.kde.org/r/102588/diff
> 
> 
> Testing
> -------
> 
> The additional message is only shown when there are more than the actual session active.
> 
> 
> Thanks,
> 
> Jaime Torres
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110913/9822c898/attachment.htm>