Review Request: middle click to close tabs

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102288/#review6390
-----------------------------------------------------------


This review has been submitted with commit c345b4cbda1431bdd0a8920173e155cb7453d9fe by Marius Knaust to branch frameworks.

- Commit


On Aug. 10, 2011, 3:50 p.m., Marius Knaust wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102288/
> -----------------------------------------------------------
> 
> (Updated Aug. 10, 2011, 3:50 p.m.)
> 
> 
> Review request for kdelibs and Thomas McGuire.
> 
> 
> Summary
> -------
> 
> I did a fix to the kmail bug 207270 https://projects.kde.org/projects/kde/kdepim/repository/revisions/569903cef49e4e40b5eac86ec052a07f5d57b231 and I thought it would be nice to have a consistent behavour throughout all applications.
> With this patch is it possible to close tabs with a middlelick if the tabs are closeable, otherwise it will emit a mouseMiddleClick signal like befor. Therefore it shouldn't effect existing implementations.
> Also the closed tab won't get the focus while closing, like dolphin did it.
> The "compatibility feature for old middle mouse tab moving" is still working.
> 
> 
> Diffs
> -----
> 
>   kdeui/widgets/ktabbar.cpp b9a790b 
> 
> Diff: http://git.reviewboard.kde.org/r/102288/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marius
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110910/cefbd919/attachment.htm>