Proposal to use QIcon in APIs in KF5.

[Boudewijn Rempt]

On Wednesday 07 September 2011 Sep, Olivier Goffart wrote:
> On Wednesday 07 September 2011 08:53:25 Boudewijn Rempt wrote:
> > On Wednesday 07 September 2011 Sep, John Layt wrote:
> > > Porting a dozen or so lines from KIcon(foo) to KIconFactory::icon(foo)
> > > is
> > > nowhere near the effort
> > 
> > Just to make sure that everyone has the right perspective on the size of any
> > porting effort: Calligra alone has over 1200 of KIcon(foo) lines. 
> 
> Try this command:
> 
> git grep -O"sed -i 's/KIcon(/QIcon::fromTheme(/g'" KIcon
> 
> and I am pretty sure this simple line 'port' over 99%
> 

I'm sure you're mostly right. I'm also sure that as soon as there's the assumption that any change only affects a dozen or so lines, but in fact affects a hundred dozen lines, the assumption that the porting effort will minor will be wrong.

In other words, before changing something so it needs porting, people really should look at the real, actual codebase of a couple of big projects that might be affected.

-- 
Boudewijn Rempt
http://www.valdyas.org, http://www.krita.org, http://www.boudewijnrempt.nl