Review Request: Add Configure Desktop Search button (to open Nepomuk KCM) into Nepomukcontroller Statuswidget

Sebastian Trueg sebastian at trueg.de
Tue Sep 6 10:13:07 BST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102523/#review6294
-----------------------------------------------------------


The weird thing here is that this widget can also be opened from the KCM. Thus, the KCM could start itself. Not a great idea. Maybe we should stick to the action in the context menu of the system tray icon for now. Or you make the button optional.

- Sebastian


On Sept. 3, 2011, 4:22 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102523/
> -----------------------------------------------------------
> 
> (Updated Sept. 3, 2011, 4:22 p.m.)
> 
> 
> Review request for KDE Runtime and Nepomuk.
> 
> 
> Summary
> -------
> 
> This little patch adds a "Configure Desktop Search" button to the nepomukcontroller statuswidget (the little status dialog that appears if you left-click on the nepomuk tray icon).
> I know that you can access strigi configuration via the tray icon's context menu but I often found myself opening the status dialog and then wanting to get to the config dialog from there. Can't harm, can it? :)
> 
> I also added a pause/resume icon to the suspend/resume button.
> 
> 
> Diffs
> -----
> 
>   nepomuk/kcm/statuswidget.h 11f20b6 
>   nepomuk/kcm/statuswidget.cpp f3074dd 
>   nepomuk/kcm/statuswidget.ui ab210c8 
> 
> Diff: http://git.reviewboard.kde.org/r/102523/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kai Uwe
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110906/ff327f35/attachment.htm>


More information about the kde-core-devel mailing list