Review Request: Fixed KHelpCenter Font Scaling (bug 243082)

Burkhard Lück lueck at hube-lueck.de
Mon Sep 5 09:53:45 BST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102528/#review6271
-----------------------------------------------------------

Ship it!


Tested your patch, works fine.

- Burkhard


On Sept. 4, 2011, 10:08 a.m., Jure Repinc wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102528/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2011, 10:08 a.m.)
> 
> 
> Review request for KDE Runtime.
> 
> 
> Summary
> -------
> 
> When user clicked a button to change font size the entire document was
> zoomed, instead of just the font size. This meant that the text would
> run past the right edge and user had to scroll horizontaly to read the 
> whole line. After this patch only the font size changes.
> 
> 
> This addresses bug 243082.
>     http://bugs.kde.org/show_bug.cgi?id=243082
> 
> 
> Diffs
> -----
> 
>   khelpcenter/mainwindow.h 6912e5a 
>   khelpcenter/mainwindow.cpp e7997b6 
>   khelpcenter/view.h ea91128 
>   khelpcenter/view.cpp 47b4713 
> 
> Diff: http://git.reviewboard.kde.org/r/102528/diff
> 
> 
> Testing
> -------
> 
> Clicking on the buttons to change font size now does the right thing.
> I changed the font size and restarted KHelpCenter and the fonsize is saved across restart.
> 
> 
> Thanks,
> 
> Jure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110905/1cb24af4/attachment.htm>


More information about the kde-core-devel mailing list