Review Request: new kded daemon to check .thumbnail directory space usage

Jaime Torres Amate jtamate at gmail.com
Fri Sep 2 16:35:01 BST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102083/
-----------------------------------------------------------

(Updated Sept. 2, 2011, 3:35 p.m.)


Review request for kdelibs.


Changes
-------

Now it deletes the oldest files in the .thumbnail directory until the files left use less or equal space than the specified.


Summary
-------

This is not yet complete, it is missing the code to delete the files, trailing spaces and comments in spanish. (coming in next patch version)

There are also some things I'm not sure how should be done...
The translations in .notifyrc and .desktop files, should be removed or just keep the lines with an empty traslation?
Classes names, method names and variable names are OK?


This addresses bug 79943.
    http://bugs.kde.org/show_bug.cgi?id=79943


Diffs (updated)
-----

  CMakeLists.txt baf36cc 
  directoryusagenotifier/CMakeLists.txt PRE-CREATION 
  directoryusagenotifier/COPYING PRE-CREATION 
  directoryusagenotifier/Messages.sh PRE-CREATION 
  directoryusagenotifier/README PRE-CREATION 
  directoryusagenotifier/cleanupdirectory.h PRE-CREATION 
  directoryusagenotifier/cleanupdirectory.cpp PRE-CREATION 
  directoryusagenotifier/directoryusagenotifier.h PRE-CREATION 
  directoryusagenotifier/directoryusagenotifier.cpp PRE-CREATION 
  directoryusagenotifier/directoryusagenotifier.desktop PRE-CREATION 
  directoryusagenotifier/directoryusagenotifier.kcfg PRE-CREATION 
  directoryusagenotifier/directoryusagenotifier.notifyrc PRE-CREATION 
  directoryusagenotifier/directoryusagenotifier_prefs_base.ui PRE-CREATION 
  directoryusagenotifier/module.h PRE-CREATION 
  directoryusagenotifier/module.cpp PRE-CREATION 
  directoryusagenotifier/settings.kcfgc PRE-CREATION 
  directoryusagenotifier/tests/CMakeLists.txt PRE-CREATION 
  directoryusagenotifier/tests/cleanupunittest.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/102083/diff


Testing (updated)
-------

It works as expected.


Thanks,

Jaime Torres

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110902/6f15826a/attachment.htm>


More information about the kde-core-devel mailing list