Review Request: plasma_applet_folderview - folder previews on mouse hover

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102300/#review6230
-----------------------------------------------------------

Ship it!


just remove the context menu integration and the rest seems to work just fine. nice :)

do you have a commit account, or do you need one of us to push it to master for you?


plasma/applets/folderview/folderview.cpp
<http://git.reviewboard.kde.org/r/102300/#comment5486>

    doesn't need to be in the action collection (and the indentation here is wrong :)



plasma/applets/folderview/folderview.cpp
<http://git.reviewboard.kde.org/r/102300/#comment5485>

    don't think this needs to be in the context menu


- Aaron J.


On Sept. 1, 2011, 10:56 a.m., Greg T wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102300/
> -----------------------------------------------------------
> 
> (Updated Sept. 1, 2011, 10:56 a.m.)
> 
> 
> Review request for KDE Base Apps and Plasma.
> 
> 
> Summary
> -------
> 
> Hello, this is my attempt to resolve Bug 250703. The diff adds a gui option in the settings dialog which configures the "click to view" option. It was quite fun because most of the time I didn't know what I'm doing :)
> 
> 
> This addresses bug 250703.
>     http://bugs.kde.org/show_bug.cgi?id=250703
> 
> 
> Diffs
> -----
> 
>   plasma/applets/folderview/folderview.h 35a0625 
>   plasma/applets/folderview/folderview.cpp 6e95c40 
>   plasma/applets/folderview/folderviewDisplayConfig.ui 961296d 
>   plasma/applets/folderview/iconview.h 4d736c5 
> 
> Diff: http://git.reviewboard.kde.org/r/102300/diff
> 
> 
> Testing
> -------
> 
> it compiles fine on kde 4.6.5 and does also work.
> 
> 
> Thanks,
> 
> Greg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110902/cb4cca7f/attachment.htm>