Review Request: DrKonqi uses a more flexible way to retrieve the version

[George Kiagiadakis]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102497/#review6206
-----------------------------------------------------------

Ship it!


I like this. Html parsing-- :D


drkonqi/findconfigdatajob.cpp
<http://git.reviewboard.kde.org/r/102497/#comment5460>

    Missing a default statement here. Something like
    
    default:
        Q_ASSERT(false);
    
    Btw, sticking to the kdelibs coding style would be a good idea:
    http://techbase.kde.org/Policies/Kdelibs_Coding_Style#Switch_statements


- George


On Aug. 31, 2011, 5:14 p.m., Matthias Fuchs wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102497/
> -----------------------------------------------------------
> 
> (Updated Aug. 31, 2011, 5:14 p.m.)
> 
> 
> Review request for KDE Runtime and Darío Andrés Rodríguez.
> 
> 
> Summary
> -------
> 
> Instead of relying on the bug reporting page this patch uses config.cgi to retrieve the version of a specified product.
> 
> 
> Diffs
> -----
> 
>   drkonqi/CMakeLists.txt 10c1846 
>   drkonqi/bugzillalib.h 1c7e895 
>   drkonqi/bugzillalib.cpp 7664650 
>   drkonqi/findconfigdatajob.h PRE-CREATION 
>   drkonqi/findconfigdatajob.cpp PRE-CREATION 
>   drkonqi/productmapping.cpp a58e240 
>   drkonqi/tests/bugzillalibtest/CMakeLists.txt c85f8fd 
> 
> Diff: http://git.reviewboard.kde.org/r/102497/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matthias
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110901/3ab7af7c/attachment.htm>