Review Request: kfileplaceeditdialog lineedit too small

[Christoph Feck]

> On Oct. 5, 2011, 11:30 a.m., David Faure wrote:
> > Why the setMaxLength?? What if one wants to type in a long URL?
> > 
> > Also, I can't reproduce the bug here (kde-4.7), but maybe only because the big icon button makes the dialog quite large?
> 
> Greg T wrote:
>     indeed, the setmaxLength was stupid
>     
>     it's quite small on 4.6.5 http://wstaw.org/m/2011/10/05/plasma-desktopF27745.jpg
>     
>
> 
> David Faure wrote:
>     Ah I see, it's the german translation which makes the label longer ("Choose an icon" -> "Wählen Sie ein Symbol aus"), leaving less room for the lineedits.
>     
>     Patch 3 looks good, although I can't help but think there's a bug if a set*Width() call takes a height() as value :-) But I'll trust Christoph on this one.
> 
> Peter Penz wrote:
>     > Patch 3 looks good, although I can't help but think there's a bug if a
>     > set*Width() call takes a height() as value :-) But I'll trust Christoph on this one.
>     
>     Using QFontMetrics::averageCharWidth() might be an alternative in comparison to use the height as reference for calculating the width (but probably this has some drawbacks I'm not aware of).
> 
> Christoph Feck wrote:
>     First, averageCharWidth() is slow. It goes through every character to compute the average. Second, that average might be skewed when there are broken characters in the font.
>     
>     I'll add a comment why the lineedits width depends on the fonts height.
> 
> Greg T wrote:
>     Hey is your patch already submitted?

Yes, see the bug report. But appearantly, the commit hook did not close the review request. Please mark it as submitted.


- Christoph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102751/#review7117
-----------------------------------------------------------


On Oct. 5, 2011, 6:22 p.m., Greg T wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102751/
> -----------------------------------------------------------
> 
> (Updated Oct. 5, 2011, 6:22 p.m.)
> 
> 
> Review request for Dolphin and kdelibs.
> 
> 
> Description
> -------
> 
> Hi, this patch sets a minimum size for the widget. 
> 
> 
> This addresses bug 266435.
>     http://bugs.kde.org/show_bug.cgi?id=266435
> 
> 
> Diffs
> -----
> 
>   kfile/kfileplaceeditdialog.cpp d798b4d 
> 
> Diff: http://git.reviewboard.kde.org/r/102751/diff/diff
> 
> 
> Testing
> -------
> 
> it's working
> 
> 
> Thanks,
> 
> Greg T
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20111028/058ff4fa/attachment.htm>