Review Request: Cleanup the use of HTTPProtocol::httpClose

Dawit Alemayehu adawit at
Tue Oct 25 16:55:03 BST 2011

This is an automatically generated e-mail. To reply, visit:

(Updated Oct. 25, 2011, 3:55 p.m.)

Review request for kdelibs and Andreas Hartmetz.


Updated patch


This patch cleans up where and under what circumstances httpClose gets called. This is done to avoid unnecessary invocation of httpClose. With this patch the function will only get called under the following circumstances:

#1. from functions that only call proceedUntilResponseHeader directly.
#2. from proceedUntilResponseContent.
#3. from error
#4. from davFinished.

The main purpose of this change is to avoid httpClose being called multiple times on every GET request which is by far the most invoked call.

Diffs (updated)

  kioslave/http/http.h 4c62841 
  kioslave/http/http.cpp 235ce7d 




Dawit Alemayehu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-core-devel mailing list