Review Request: [PATCH] Change HTML thumbnail generator to kdewebkit

[Dawit Alemayehu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101365/
-----------------------------------------------------------

(Updated Oct. 23, 2011, 4:19 p.m.)


Review request for KDE Runtime.


Changes
-------

Updated purpose of the patch.


Summary (updated)
-----------------

[PATCH] Change HTML thumbnail generator to kdewebkit


Description (updated)
-------

This patch changes the thumbnail generate to use QtWebKit (through kdewebkit) such that it can be used in the leaner mobile builds [1]. Note that this patch was originally proposed to resolve http://bugs.kde.org/show_bug.cgi?id=248478, but that issue has already been addressed. As such, this change is very optional.

[1] http://lists.kde.org/?l=kde-core-devel&m=130813188205168&w=2.


Diffs
-----

  kioslave/thumbnail/CMakeLists.txt 9789109 
  kioslave/thumbnail/htmlcreator.h 6903db7 
  kioslave/thumbnail/htmlcreator.cpp c623606 

Diff: http://git.reviewboard.kde.org/r/101365/diff/diff


Testing (updated)
-------

Tested by generating thumbnails on the Qt HTML documentation folder (thousands of html files).


Thanks,

Dawit Alemayehu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20111023/aee1f105/attachment.htm>