Review Request: KActivities requires Soprano 2.7 to compile

[Rex Dieter]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102893/#review7432
-----------------------------------------------------------


Wouldn't it make more sense to up the minimum kdelibs requirement to 4.7 (which already depends on the newer soprano?)

- Rex Dieter


On Oct. 16, 2011, 10:29 a.m., Ralf Jung wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102893/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2011, 10:29 a.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> I tried compiling KActivities with Soprano 2.6 installed, which resulted in compile errors. After upgrading to Soprano 2.7, these were fixed.
> 
> I assume this means that KActivities actually requires Soprano 2.7? If that's the case, IMHO attached patch should be applied to detect that at cmake-time. (I also hope this is the right list, there is no "kactivities" group in reviewboard)
> 
> 
> Diffs
> -----
> 
>   service/CMakeLists.txt 5489b6b 
> 
> Diff: http://git.reviewboard.kde.org/r/102893/diff/diff
> 
> 
> Testing
> -------
> 
> compile-tested
> 
> 
> Thanks,
> 
> Ralf Jung
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20111017/ac0cd14b/attachment.htm>