Review Request: Improved proxy data caching in KProtocolManager

Commit Hook null at kde.org
Sat Oct 15 03:39:54 BST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102840/#review7350
-----------------------------------------------------------


This review has been submitted with commit 0ea92d0b09f282d745de9444ed5c0c9decb06db0 by Dawit Alemayehu to branch KDE/4.7.

- Commit Hook


On Oct. 13, 2011, 7:30 p.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102840/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2011, 7:30 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> The attached patch attempts to improve proxy lookup performance by using QCache to cache the proxy data for the last 100 (QCache default) lookups instead of caching just the last lookup. The current approach, where only the last lookup is cached, is useless whenever two consecutive requests for proxy data are for different URLs.
> 
> 
> Diffs
> -----
> 
>   kio/kio/kprotocolmanager.cpp 92519e4 
> 
> Diff: http://git.reviewboard.kde.org/r/102840/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20111015/d58321b1/attachment.htm>


More information about the kde-core-devel mailing list