Review Request: facePerm is a KDM option, unrelated to the user setting his face (for other apps)

[Steven Sroka]

No tabs, 4 spaces instead.

http://techbase.kde.org/Policies/Kdelibs_Coding_Style



On 12 October 2011 12:55, Ralf Jung <ralfjung-e at gmx.de> wrote:

>    This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102799/
>   Review request for KDE Base Apps.
> By Ralf Jung.
>
> *Updated Oct. 12, 2011, 4:55 p.m.*
> Changes
>
> Removed unnecessary whitespace changes, and the new "Remove image" button (I will create a separate request for it).
>
> I always used the coding style of the function I changed, the file contains a mixture of tabs and 2-whitespace indents. What is the kdelibs style?
>
>   Description
>
> Currently, the "User account & password" KCM refuses to change the user image if KDM is set up not to use user images. That however does not make much sense, all this applet does is writing the image to ~/.face.icon, which the user can do manually anyway. The fact that KDM might or might not actually display this image in the user selection is unrelated, as KDM is not even the only user of this file: Plasma Kickoff displays it, and maybe more apps use it (GDM uses a different file, though)
>
> This patch therefore removes the check for the KDM settings and makes the KCM simply manage the .face.icon file. It does not fall back to the system default if the user image does not exist, as Plasma Kickoff does not do that either. The patch also adds a button in the "Change face" dialogue to remove the user image, to make it possible to go back to the default state again.
>
> After changing the image, the user still has to log off and on again for Plasma to use it - Plasma would have to somehow listen to changes to that file. I don't know if that is desired.
>
>   Testing
>
> Compiled and verified that the KCM now behaves as desired.
>
>   *Bugs: * 183245 <http://bugs.kde.org/show_bug.cgi?id=183245>
> Diffs (updated)
>
>    - kdepasswd/kcm/main.h (320126f)
>    - kdepasswd/kcm/main.cpp (5ce1961)
>
> View Diff <http://git.reviewboard.kde.org/r/102799/diff/>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20111013/8110952a/attachment.htm>