Review Request: Cleanup the use of HTTPProtocol::httpClose

[Andreas Hartmetz]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102801/#review7282
-----------------------------------------------------------


This changeset changes some important parts without obvious (to me) gain.
Before I spend an hour or two thinking through all the cases, which may or may not catch potential regressions, I'd like to know what this does for us.
The current approach of acting a bit dumb seems more robust.

- Andreas Hartmetz


On Oct. 8, 2011, 5:16 a.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102801/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2011, 5:16 a.m.)
> 
> 
> Review request for kdelibs and Andreas Hartmetz.
> 
> 
> Description
> -------
> 
> This patch cleans up where and under what circumstances httpClose gets called. This is done to avoid unnecessary invocation of httpClose. With this patch the function will only get called under the following circumstances:
> 
> #1. from functions that only call proceedUntilResponseHeader directly.
> #2. from proceedUntilResponseContent.
> #3. from error
> #4. from davFinished.
> 
> The main purpose of this change is to avoid httpClose being called multiple times on every GET request which is by far the most invoked call.
> 
> 
> Diffs
> -----
> 
>   kioslave/http/http.h 4c62841 
>   kioslave/http/http.cpp 2862707 
> 
> Diff: http://git.reviewboard.kde.org/r/102801/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20111012/806ab733/attachment.htm>