Review Request: Avoid possible null pointer dereferences in khtml

[Jaime Torres Amate]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102794/
-----------------------------------------------------------

Review request for kdelibs.


Description
-------

The real changes are:
Avoid possible null pointer dereferences in khtml.
The common check
  if (a && something(a)) do return bla(a) else blabla(a)       uses blabla(a) with null a. changed to
  if (a) { if something(a)) do return bla(a) else blabla(a) }

As a side effect:
kate has removed a lot of tailing spaces in the edited files.
Avoid a possible crash checking the index limit before accesing the array.
Move some variables inside the #ifdef block where they are used


Diffs
-----

  khtml/css/css_valueimpl.cpp 3fb2898 
  khtml/ecma/kjs_window.cpp 0e7394b 
  khtml/html/htmltokenizer.cpp b64e83d 
  khtml/java/kjavaappletserver.cpp 234c6f3 
  khtml/khtml_part.cpp 53929fa 
  khtml/khtmlimage.cpp c6e6366 
  khtml/khtmlview.cpp 28dbac3 
  khtml/rendering/render_form.cpp c15247a 
  khtml/rendering/render_table.cpp 5b07714 
  khtml/xpath/util.cpp 079008d 

Diff: http://git.reviewboard.kde.org/r/102794/diff/diff


Testing
-------

no regressions in kdelibs tests.


Thanks,

Jaime Torres Amate

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20111007/7f1a430f/attachment.htm>