Review Request: kfileplaceeditdialog lineedit too small

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102751/#review7117
-----------------------------------------------------------


Why the setMaxLength?? What if one wants to type in a long URL?

Also, I can't reproduce the bug here (kde-4.7), but maybe only because the big icon button makes the dialog quite large?

- David Faure


On Oct. 4, 2011, 8:02 p.m., Greg T wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102751/
> -----------------------------------------------------------
> 
> (Updated Oct. 4, 2011, 8:02 p.m.)
> 
> 
> Review request for Dolphin and kdelibs.
> 
> 
> Description
> -------
> 
> Hi, this patch sets a minimum size for the widget. 
> 
> 
> This addresses bug 266435.
>     http://bugs.kde.org/show_bug.cgi?id=266435
> 
> 
> Diffs
> -----
> 
>   kfile/kfileplaceeditdialog.cpp d798b4d 
> 
> Diff: http://git.reviewboard.kde.org/r/102751/diff/diff
> 
> 
> Testing
> -------
> 
> it's working
> 
> 
> Thanks,
> 
> Greg T
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20111005/09050425/attachment.htm>