Review Request: fix sycoca off by one

Commit Hook null at kde.org
Tue Oct 4 15:48:02 BST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102748/#review7080
-----------------------------------------------------------


This review has been submitted with commit 48b6be7d90926998849c1b9e3fbe6a5334fe64e9 by Jaime Torres to branch frameworks.

- Commit Hook


On Sept. 30, 2011, 4:58 p.m., Jaime Torres Amate wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102748/
> -----------------------------------------------------------
> 
> (Updated Sept. 30, 2011, 4:58 p.m.)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Description
> -------
> 
> fixing sycoca, this time fixing the off by one in ALL the methods (not like in the previous attempt).
> 
> 
> Diffs
> -----
> 
>   kdecore/sycoca/ksycocadict.cpp 4be935b 
> 
> Diff: http://git.reviewboard.kde.org/r/102748/diff/diff
> 
> 
> Testing
> -------
> 
> git pull kdelibs with modifications.
> Compiled/installed kdelibs in the kde session (linking all the .so and programs again).
> None of the kde programs crashes, nor any protocol is missing.
> No valgrind errors (except fontconfig).
> 
> 
> Thanks,
> 
> Jaime Torres Amate
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20111004/8d03e1b4/attachment.htm>


More information about the kde-core-devel mailing list