Review Request: fix sycoca off by one

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102748/#review7025
-----------------------------------------------------------


Looks ok, but make sure to increase the sycoca version number (and run the unittests in kdecore) :)


kdecore/sycoca/ksycocadict.cpp
<http://git.reviewboard.kde.org/r/102748/#comment6201>

    Indentation issue?


- David Faure


On Sept. 30, 2011, 4:58 p.m., Jaime Torres Amate wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102748/
> -----------------------------------------------------------
> 
> (Updated Sept. 30, 2011, 4:58 p.m.)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Description
> -------
> 
> fixing sycoca, this time fixing the off by one in ALL the methods (not like in the previous attempt).
> 
> 
> Diffs
> -----
> 
>   kdecore/sycoca/ksycocadict.cpp 4be935b 
> 
> Diff: http://git.reviewboard.kde.org/r/102748/diff/diff
> 
> 
> Testing
> -------
> 
> git pull kdelibs with modifications.
> Compiled/installed kdelibs in the kde session (linking all the .so and programs again).
> None of the kde programs crashes, nor any protocol is missing.
> No valgrind errors (except fontconfig).
> 
> 
> Thanks,
> 
> Jaime Torres Amate
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20111003/24f7be28/attachment.htm>