Review Request: nepomuk/services/storage/datamanagementmodel.h fix to allow compiling on apple's gcc 4.2.1

[Kurt Hindenburg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102753/
-----------------------------------------------------------

(Updated Oct. 2, 2011, 2:13 p.m.)


Review request for KDE Runtime and Nepomuk.


Description (updated)
-------

Without this patch, nepomuk won't build on MacOSX Lion w/ i686-apple-darwin11-llvm-g++-4.2 (GCC) 4.2.1 (Based on Apple Inc. build 5658) (LLVM build 2335.15.00)

IIRC PovAddict helped figure it out on IRC.


In file included from /Volumes/ExtraHD/Projects/KDE/kde4/trunk/src/kde/kde-runtime/nepomuk/services/storage/datamanagementmodel.cpp:23:
/Volumes/ExtraHD/Projects/KDE/kde4/trunk/src/kde/kde-runtime/nepomuk/services/storage/datamanagementmodel.h:159: error: expected ‘,’ or ‘...’ before ‘>’ token
/Volumes/ExtraHD/Projects/KDE/kde4/trunk/src/kde/kde-runtime/nepomuk/services/storage/datamanagementmodel.h:191: error: expected ‘,’ or ‘...’ before ‘>’ token
/Volumes/ExtraHD/Projects/KDE/kde4/trunk/src/kde/kde-runtime/nepomuk/services/storage/datamanagementmodel.h:207: error: expected ‘,’ or ‘...’ before ‘>’ token
/Volumes/ExtraHD/Projects/KDE/kde4/trunk/src/kde/kde-runtime/nepomuk/services/storage/datamanagementmodel.h:159: error: wrong number of template arguments (1, should be 2)
/opt/local/include/QtCore/qdatastream.h:66: error: provided for ‘template<class Key, class T> class QHash’
/Volumes/ExtraHD/Projects/KDE/kde4/trunk/src/kde/kde-runtime/nepomuk/services/storage/datamanagementmodel.h:159: error: default argument missing for parameter 6 of ‘void Nepomuk::DataManagementModel::storeResources(const Nepomuk::SimpleResourceGraph&, const QString&, Nepomuk::StoreIdentificationMode, Nepomuk::StoreResourcesFlags, const QHash<QUrl, QVariant>&, QVariant)’
/Volumes/ExtraHD/Projects/KDE/kde4/trunk/src/kde/kde-runtime/nepomuk/services/storage/datamanagementmodel.h:191: error: wrong number of template arguments (1, should be 2)


Diffs
-----

  nepomuk/services/storage/datamanagementmodel.h 2c26161 

Diff: http://git.reviewboard.kde.org/r/102753/diff/diff


Testing
-------


Thanks,

Kurt Hindenburg

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20111002/23caea89/attachment.htm>