Review Request: Fix Date Display in dolphin info panel

[Xuetian Weng]

> On Nov. 30, 2011, 9:30 p.m., Sebastian Trueg wrote:
> > kio/kfile/kfilemetadatareaderprocess.cpp, line 170
> > <http://git.reviewboard.kde.org/r/103300/diff/1/?file=42530#file42530line170>
> >
> >     Why do you need to load the kio4 catalog?

Emm.. I'm not very sure for this part, but localization will not work without an active catalog.
And for this file, its translation is extracted to kio4.pot (you can check kio/Messages.sh) , so I think kio4 is the suitable one.


- Xuetian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103300/#review8628
-----------------------------------------------------------


On Nov. 30, 2011, 9:17 p.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103300/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2011, 9:17 p.m.)
> 
> 
> Review request for kdelibs and Nepomuk.
> 
> 
> Description
> -------
> 
> The date in dolphin info panel is passed by kfilemetadatareader directly. So all the localization work should be done at the kfilemetadatareader side.
> There are two problems.
> 1. date given by nepomuk is stored as UTC time, needed to convert to localtime.
> 2. date localization will not work without a KComponentData.
> 
> 
> Diffs
> -----
> 
>   nepomuk/utils/utils.cpp e81615a 
>   kio/kfile/kfilemetadatareaderprocess.cpp 03ff887 
> 
> Diff: http://git.reviewboard.kde.org/r/103300/diff/diff
> 
> 
> Testing
> -------
> 
> Works for me.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20111130/0b75d8d6/attachment.htm>